Wanted to test this one, but I'm getting an error when running npm run dev (after a clean npm install):

Build Progress: [==============================] 100%
[1] 
[1] > [email protected] dev:packages /Users/bart/Code/WunderBart/gutenberg
[1] > node ./bin/packages/watch.js
[1] 
[1] internal/modules/cjs/loader.js:800
[1]     throw err;
[1]     ^
[1] 
[1] Error: Cannot find module '/Users/bart/Code/WunderBart/gutenberg/packages/edit-site/package.json'
[1] Require stack:
[1] - /Users/bart/Code/WunderBart/gutenberg/bin/packages/get-packages.js
[1] - /Users/bart/Code/WunderBart/gutenberg/bin/packages/watch.js
[1]     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
[1]     at Function.Module._load (internal/modules/cjs/loader.js:690:27)
[1]     at Module.require (internal/modules/cjs/loader.js:852:19)
[1]     at require (internal/modules/cjs/helpers.js:74:18)
[1]     at hasModuleField (/Users/bart/Code/WunderBart/gutenberg/bin/packages/get-packages.js:35:21)
[1]     at apply (/Users/bart/Code/WunderBart/gutenberg/node_modules/lodash/lodash.js:476:27)
[1]     at /Users/bart/Code/WunderBart/gutenberg/node_modules/lodash/lodash.js:5259:20
[1]     at arrayEvery (/Users/bart/Code/WunderBart/gutenberg/node_modules/lodash/lodash.js:558:12)
[1]     at /Users/bart/Code/WunderBart/gutenberg/node_modules/lodash/lodash.js:5258:18
[1]     at apply (/Users/bart/Code/WunderBart/gutenberg/node_modules/lodash/lodash.js:474:27) {
[1]   code: 'MODULE_NOT_FOUND',
[1]   requireStack: [
[1]     '/Users/bart/Code/WunderBart/gutenberg/bin/packages/get-packages.js',
[1]     '/Users/bart/Code/WunderBart/gutenberg/bin/packages/watch.js'
[1]   ]
[1] }
[1] npm 
[1] ERR! code ELIFECYCLE
[1] npm ERR! errno 1
[1] npm 
[1] ERR! [email protected] dev:packages: `node ./bin/packages/watch.js`
[1] npm ERR! Exit status 1
[1] npm ERR! 
[1] npm ERR! Failed at the [email protected] dev:packages script.
[1] npm 
[1] ERR! This is probably not a problem with npm. There is likely additional logging output above.

Master branch is working fine for me.

Env:

• node v12.13.1 (from .nvmrc)
• npm v6.12.1

@marekhrabe and I are going to take this up full time again starting tomorrow.

@youknowriad I think this feature is important for continuity with WP Core. However, we cannot land it until the REST API supports Menus.

However, the REST API team already have a feature Plugin for Menu endpoints that needs testing. We can develop against this Plugin.

However, in order to merge the feature we'll need to wait on WP Core to release the Menu endpoints. That could take some time.

I felt it was worth asking - is there any way we would consider adding an "experimental" endpoint to Gutenberg to allow READ access to Menus as a stop-gap until the WP Core REST API is updated with an official endpoint?

cc @apeatling

@getdave this seems like a good use case to bring the required endpoints from that plugin to Gutenberg and test it properly.

@youknowriad The menus endpoint is being activily developed in the plugin still. We still have one PR that is outstand. We then need to have unit tests and tidy up the code. So to me, this still makes sense for this to live in it's own plugin for now.

If you want to use it in your code base, you could bring it in using composer?

If you want to use it in your code base, you could bring it in using composer?

I don't mind using composer here personally, The concern is the extra tooling but we can probably try it.

I have created a PR for menu endpoints - #20292

Size Change: +2.07 kB (0%)

Total Size: 1.13 MB

_{compressed-size-action}

Thanks for working on this @getdave.

You are very welcome. Thanks for all the reviews and help. Also @draganescu (and others).

I still feel like this is a lot of code to add to the one file (navigation/edit.js), but having said that, the feature is working well.

Agreed. For clarity for others coming here in the future, the feature has now been:

• manually tested by several contributors.
• [approved by the feature's Design lead] (Nav block: enable creation from existing WP Menus #18869 (review)) @/karmatosed.
• approved by @/talldan.
• covered by an updated suite of e2e tests.

This makes me confident it will serve the need although there are certainly some UX and a11y improvements that could be looked at. As a result I've raised a number of followup issues that have been added to the Navigation project board.

I'll look to merge this asap.

Great work Dave!!

This feature seems merged, but in the latest Wordpress version I can't find any Nav block...

Why? How is it called?

Hey @collimarco Marco

The Nav block is for the moment only present in the Gutenberg plugin.
Here is it with the Gutenberg plugin activated:

It is missing when the Gutenberg plugin is not activated.

The Nav block was not included into WordPress 5.8 because it is still in a kind of experimental phase. Which means it is for now only included in the Gutenberg plugin. It should likely be included into WordPress 5.9 when it is released in December.